graph-genome / component_segmentation

Read in ODGI Bin output and identify co-linear components
Apache License 2.0
3 stars 4 forks source link

Bin ranges #37

Closed dimatr closed 4 years ago

dimatr commented 4 years ago

should fix #36

subwaystation commented 4 years ago

I did more extensive testing from odgi build to odgi bin to CS. Looks good from my side.

subwaystation commented 4 years ago

We will JSON_VERSION = 11.

josiahseaman commented 4 years ago

Version bump hasn't been committed yet.

subwaystation commented 4 years ago

I still need to bring in new example data.

josiahseaman commented 4 years ago

Checking this now. Don't worry about the merge conflict, it's minor.

josiahseaman commented 4 years ago

The current data needs to be updated from odgi. data/run1.B1phi1.i1.seqwish.w1000.json doesn't have a header, so it never throws a version error.

subwaystation commented 4 years ago

Oh man, these conflicts.....

josiahseaman commented 4 years ago

@subwaystation All done! In the future, please note that we won't be tracking fasta chunks beyond bin width 1.