search

graph-genome / graph-genome.github.io

Graph Genome Documentation
5 stars 5 forks source link

Missing Links between filled Components #18

Open SingingMeerkat opened 4 years ago

SingingMeerkat commented 4 years ago

Pantograph_trueColors

I have this on screen after having only npm install and npm start done on the Schematize repo.

I have some concerns about components n°4-7 here, they do not seem to be connected altogether for the given path (the highlighted one below), even though the component is marked as present for that path. Shouldn't there be a Link, either an Adjacent one or a Departure/Arrival between those? What are the connections there? I do not feel that this is normal behaviour. Pantograph_no_Link

I would have expect at least unconnected Departure/Arrival Link if there is no Adjacent one, eg. a combination of the following: Pantograph_possiblelinks

If the components were empty, it would explain the absence of any Link, but that is not the case here...

Maybe it is just something I misunderstood, but I could not find any similar situation in the specifications (there is always a Link between filled Components)

subwaystation commented 4 years ago

You have a keen eye @SingingMeerkat. I took a closer look at the visualized data again. My impression is that indeed something fishy is going on. Such paths should have been connected either via link (which they are not, at least not visually), or via such a dark connection. I will take a look at the data itself now.

Or does @josiahseaman has any immediate explanation?

subwaystation commented 4 years ago

I have no explanation of why we would not draw a default left to right connection. From my understanding, that would be the logical way to do. If @josiahseaman agrees, then you actually identyfied a major bug.

josiahseaman commented 4 years ago

It's not what I would call a major bug, but it's certainly not good visual communication. Sorry it looks bad and thanks for raising the question.

Explanation

We have not yet implemented floating point logic for cell coloring schematize#37. That means that "occupants" and "participants" are currently using threshold cutoffs. Anything close to the line can waiver between the on/off state. Let's check this again once 37 is implemented. With binning "which path does the individual take" actually becomes less obvious, so we definitely want to test once it's valid to do so. This is a low priority issue for now. In the future, please open rendering bugs (of which there are a handful) in Schematize repo, not here.

josiahseaman commented 4 years ago

I'll mention there's a related bug where sometimes you see a LinkColumn with no filled cells. I suspect this is because we're cropping off the bottom of the canvas, because if you turn on Vertical Compression something always appears.