search

graph-gophers / dataloader

Implementation of Facebook's DataLoader in Golang
MIT License
1.21k stars 75 forks source link

v2: Ensure len(errors) in ResultMany equals len(data) #27

Closed tonyghita closed 7 years ago

tonyghita commented 7 years ago

This simplifies the error handling in LoadMany and ensures that every element in the response []interface{} has a corresponding error. Resolves #25.

This change is Reviewable

codecov[bot] commented 7 years ago

Codecov Report

Merging #27 into v2 will decrease coverage by 0.09%. The diff coverage is 75%.

@@            Coverage Diff            @@
##               v2      #27     +/-   ##
=========================================
- Coverage   94.97%   94.88%   -0.1%     
=========================================
  Files           2        2             
  Lines         219      215      -4     
=========================================
- Hits          208      204      -4     
  Misses         11       11