graph-gophers / dataloader

Implementation of Facebook's DataLoader in Golang

MIT License

1.21k stars 75 forks source link

v4: Fix InMemoryCache Clear() and LoadMany() concurrency bugs #56

Closed tonyghita closed 5 years ago

tonyghita commented 5 years ago

Same as #55, but for v4.

codecov-io commented 5 years ago

Codecov Report

Merging #56 into v4 will increase coverage by 0.63%. The diff coverage is 100%.

@@            Coverage Diff             @@
##               v4      #56      +/-   ##
==========================================
+ Coverage   87.64%   88.28%   +0.63%     
==========================================
  Files           4        3       -1     
  Lines         251      256       +5     
==========================================
+ Hits          220      226       +6     
+ Misses         31       30       -1

nicksrandall commented 5 years ago

I left a comment on this change on the v3 branch. Same would apply here.

tonyghita commented 5 years ago

Fixes https://github.com/graph-gophers/dataloader/issues/49