Hi again! I noticed while debugging the intermittently failing test in https://github.com/graph-gophers/dataloader/pull/73#issuecomment-810251430 that there were two tests with that name ("allows clearAll values in cache"). The second test with this name was added in 13ae83d1. Renamed that second test so that all tests have unique names. Since this test seemed to be testing the WithClearCacheOnBatch config method more than the ClearAll method, I based the name on that. Happy to update if you have any suggestions. Thanks!
tonyghita
commented
3 years ago
Hi again! I noticed while debugging the intermittently failing test in https://github.com/graph-gophers/dataloader/pull/73#issuecomment-810251430 that there were two tests with that name ("allows clearAll values in cache"). The second test with this name was added in 13ae83d1. Renamed that second test so that all tests have unique names. Since this test seemed to be testing the
WithClearCacheOnBatchconfig method more than theClearAllmethod, I based the name on that. Happy to update if you have any suggestions. Thanks!