Panic errors from batch function should not be cached

graph-gophers / dataloader

Implementation of Facebook's DataLoader in Golang

MIT License

1.21k stars 75 forks source link

Panic errors from batch function should not be cached #86

Closed vivek-ng closed 2 years ago

vivek-ng commented 2 years ago

We currently cache panic errors from batch function. This is a problem because subsequent load calls for the same keys will continue returning panic errors without calling the batch function again. This PR fixes this issue.

vivek-ng commented 2 years ago

@pavelnikolov @tonyghita Could you review this PR when you get a chance ? Thank you!