graph-gophers / graphql-go

GraphQL server with a focus on ease of use
BSD 2-Clause "Simplified" License
4.64k stars 491 forks source link

Fixed goroutine leak in subscriptions #626

Closed korotin closed 9 months ago

korotin commented 9 months ago

We have goroutine leak here if events will happen in following order:

Described situation may seem rare, but in our project with hundreds events per second that leak happened rather often. We tested this fix in production environment and it solved the problem.

@pavelnikolov

pavelnikolov commented 9 months ago

Thank you for this fix.