search

graphaware / neo4j-framework

GraphAware Neo4j Framework
244 stars 68 forks source link

Feature request: consider slf4j for logging #11

Closed jotomo closed 10 years ago

jotomo commented 10 years ago

This project being a framework, it would make integration into an application easier if logging would not be coded against log4j, but use slf4j, so that an application can use, or keep using, a logging implementation of their chosing. In my, case I'm already using logback via slf4j. I added log4j-over-slf4j to avoid having to use logback and log4j (not sure that would even work), but I consider that a workaround. So, if such a change is still possible at this stage of development, I'd humbly ask to consider if adding slf4j is a possibility, which ideally benefits not just me ;-) Thanks!

bachmanm commented 10 years ago

Thanks very much, this is on top of our list and will be fixed in the next release.

atg103 commented 10 years ago

Merged to master, flow and 2.0. Not sure what the gh-pages is for but I can happily apply the same changes in there too if deemed necessary.

jotomo commented 10 years ago

Cool, thanks! The gh-pages branch is used for xxx.github.io pages and seems unusued in this repository. The branch doesn't have sources anyway. The situation for the neo4j-timetree repository is the same with regard to log4j vs slf4j. Could that be migrated as well? I have the sourced checked out and could create a pull request if desired.

atg103 commented 10 years ago

Aye, no probs. Consider it done ;)

jotomo commented 10 years ago

Resolved with the release of 2.1.2.9. Thanks again @atg103 !