search

graphaware / neo4j-framework

GraphAware Neo4j Framework
244 stars 68 forks source link

GraphUnit.areSameGraph(GraphDatabaseService database, String sameGraphCypher) should be static #115

Closed mcclown closed 3 years ago

mcclown commented 3 years ago

GraphUnit has a private constructor, so this method can never be called.

ikwattro commented 3 years ago

Method is public, the private constructor is on purpose.

mcclown commented 3 years ago

That's missing the point, you didn't read the title.

GraphUnit.areSameGraph(GraphDatabaseService database, String sameGraphCypher) is the only non-static method on this class. You can't create an instance of this class, so therefore this method can't be called. This method should be static.

bachmanm commented 3 years ago

Stephen, do you need a build for 4.1.x?

mcclown commented 3 years ago

@bachmanm No, I'm fine. I had a look at the source and just used GraphUnit.areSameGraph(GraphDatabaseService database, String sameGraphCypher, InclusionPolicies inclusionPolicies) instead with InclusionPolicies.all().