graphaware / neo4j-framework

GraphAware Neo4j Framework
244 stars 68 forks source link

Module throwing exception breaks atomicity #30

Closed bachmanm closed 8 years ago

bachmanm commented 9 years ago

It has always been a design decision that only throwing DeliberateTransactionRollbackException from beforeCommit() of a module actually rolls the transaction back. This should be reconsidered, because (perhaps due to programming error), partial transaction updates may occur.

Possible solution: Let all RuntimeExceptions rollback the entire transaction, but not checked exceptions.

bachmanm commented 8 years ago

cc @aleshav