search

graphaware / neo4j-framework

GraphAware Neo4j Framework
244 stars 68 forks source link

Commons module dependes on runtime module. #53

Closed jotomo closed 8 years ago

jotomo commented 8 years ago

For some (accidental, I presume) reason the commons module JAR contains a service file belonging to the runtime module, which asks Neo4j to bootstrap the GA runtime. This tightly couples commons and runtime, which causes problems for my scenario (described in https://github.com/graphaware/neo4j-framework/pull/45)

mal:~/inbox$ aunpack common-3.0.3.39.jar 
Archive:  common-3.0.3.39.jar
   creating: Unpack-4774/META-INF/
[...]
  inflating: Unpack-4774/com/graphaware/common/wrapper/Wrapper.class  
  inflating: Unpack-4774/META-INF/services/org.neo4j.kernel.extension.KernelExtensionFactory  
   creating: Unpack-4774/META-INF/maven/
   creating: Unpack-4774/META-INF/maven/com.graphaware.neo4j/
   creating: Unpack-4774/META-INF/maven/com.graphaware.neo4j/common/
  inflating: Unpack-4774/META-INF/maven/com.graphaware.neo4j/common/pom.xml  
  inflating: Unpack-4774/META-INF/maven/com.graphaware.neo4j/common/pom.properties  
common-3.0.3.39.jar: extracted to `common-3.0.3.39' (multiple files in root)

mal:~/inbox$ cat common-3.0.3.39/META-INF/services/org.neo4j.kernel.extension.KernelExtensionFactory 
com.graphaware.common.log.LoggerFactory
com.graphaware.runtime.bootstrap.RuntimeKernelExtensionFactory
bachmanm commented 8 years ago

That's a mistake. Will be fixed in the next release (next week)

jotomo commented 8 years ago

@bachmanm Thanks!