graphaware / neo4j-to-elasticsearch

GraphAware Framework Module for Integrating Neo4j with Elasticsearch
261 stars 57 forks source link

Timeout Configs Gets Overwritten #140

Closed manaschoksi closed 5 years ago

manaschoksi commented 5 years ago

readTimeout and connectionTimeout are parameters that must be tuned, to accommodate for application based delays in getting information from ElasticSearch.

Currently, both these parameters get overwritten to their default value in spite of setting them in the neo4j config.

This happens because when we set mapping using "withMapping" function of ElasticSearchConfiguration, it overwrites those timeout parameters. And within "ElasticSearchModuleBootstrapper", withMapping is always the last thing that is called. Thus those timeout configs will never come into effect.

This fix is to prevent that.

graphaware-bot commented 5 years ago

Dear @manaschoksi,

thank you very much for your Github contributions to GraphAware's software. In order for us to be able to accept and keep your contributions, we would like to ask you to download, fill in, sign, and send us a photo / scanned copy of the attached Contributor License Agreement to cla@graphaware.com .

Thank you very much in advance,

Kind Regards,

The GraphAware Team

ikwattro commented 5 years ago

Hi @manaschoksi

Thank you for your contribution. I have created a snapshot version that you can download here :

https://www.dropbox.com/s/yv3mnqlt79y9dun/graphaware-neo4j-to-elasticsearch-3.4.9.52.11-SNAPSHOT.jar?dl=0

We will make a release in the coming days.

manaschoksi commented 5 years ago

Perfect, thanks for the Snapshot. I was able to test the snapshot and it all looks good. Let me know when you plan to release.

ikwattro commented 5 years ago

@manaschoksi Thanks! Released 3.4.9.52.11 and available here : https://products.graphaware.com/download/neo4j-to-elasticsearch/graphaware-neo4j-to-elasticsearch-3.4.9.52.11.jar

manaschoksi commented 5 years ago

Great, that was fast. Thank you @ikwattro. I will also mark the issue as closed.