search

graphaware / neo4j-uuid

GraphAware Runtime Module that assigns a UUID to all nodes (and relationships) in the graph transparently
103 stars 22 forks source link

Checkstyle, DRY UuidModule's assignUuid() #27

Closed espiegelberg closed 8 years ago

espiegelberg commented 8 years ago

I've recently done some work with Neo4j modules and the GraphAware Framework. Because the UUID module is useful and serves as an excellent example and case study for getting familiar with modules, I thought I would share what I think are some (trivial) improvements.

This pull request resolves some Checkstyle warnings (cleaning of unused imports, removal of some unused code, the suppression of a few unchecked conversions by adding @SupressWarnings, etc) and includes a bit of refactoring to DRY/consolidate the assignUuid() within the UuidModule. I tend to prefer working with PropertyContainers rather than explicitly having separate methods/code that work with Nodes and Relationships individually. This is largely a matter of personal style obviously, so please apply these changes as you see fit.

graphaware-bot commented 8 years ago

Dear @espiegelberg,

thank you very much for your Github contributions to GraphAware's software. In order for us to be able to accept and keep your contributions, we would like to ask you to download, fill in, sign, and send us a photo / scanned copy of the attached Contributor License Agreement to cla@graphaware.com .

Thank you very much in advance,

Kind Regards,

The GraphAware Team

bachmanm commented 8 years ago

Thanks @espiegelberg !