search

graphcommerce-org / graphcommerce

GraphCommerce® is a headless storefront replacement for Magento 2 (PWA), that delivers a faster, better user experience. Fully customizable (React, Next.js) and open-source.
https://www.graphcommerce.org
Other
303 stars 67 forks source link

Wrong parsing of limit parameter #1906

Closed vahe-templi closed 1 year ago

vahe-templi commented 1 year ago

Describe the Bug

bug parseParams function in @graphcommerce/magento-product/components/ProductListItems/filteredProductList. It should use the value of the "limit" parameter.

Expected Behavior

It should use the value of the "limit" parameter.

To Reproduce

It uses the "limit" string.

paales commented 1 year ago

Fixed in https://github.com/graphcommerce-org/graphcommerce/pull/1914, will be available with the next GraphCommerce release

paales commented 1 year ago

@vahe-templi We'll be implementing some additional funtionality to make it work out of the box

paales commented 1 year ago

Any objection to renaming it to page-size in the URL, seems more logical than limit which is more of an SQL concept.

paales commented 1 year ago

I've added screenshots to the PR https://github.com/graphcommerce-org/graphcommerce/pull/1914 Please test out the functionality on the demo branch: https://graphcommerce-git-fix-various-graphcommerce.vercel.app/nl/men/photography (branch is currently deploying, should be done in 10min)

Without any further feedback I'll proceed with merging the PR

vahe-templi commented 1 year ago

Thank you @paales !