graphcore-research / pyscf-ipu

PySCF on IPU
https://github.com/graphcore-research/pyscf-ipu#readme
Apache License 2.0
42 stars 2 forks source link

Implementation of integrals over Gaussian orbitals #87

Closed hatemhelal closed 1 year ago

hatemhelal commented 1 year ago

This patch adds the following objects:

Adds implementations as derived in Gaussian-expansion methods for molecular integrals for the following:

All these integrals are implemented at the Primitive level and the results from these are used to build up the result of integration over the entire Basis.

Adds the following dependencies:

Also adds a github action for running tests using the jax cpu backend by default and a few tests that run on the IPU model. Note that the ERI tests cannot be tested on the github action runners due to requiring more than the 7GB of memory available.

awf commented 1 year ago

in Gaussian-expansion methods for molecular integrals f This link is paywalled? Is there an openly viewable equivalent?

hatemhelal commented 1 year ago

I wonder if it might be better to move the folder e.g.

pyscf-ipu/pyscf_ipu/experimental -> pyscf-ipu/experimental/jax-integrals

I'd like to leave this until it becomes clearer how much we are going to build into the experimental module. Either at some point functionality here stops becoming experimental and is moved into a top-level namespace or it stops being useful and we might as well delete it right?