search

graphdeco-inria / gaussian-splatting

Original reference implementation of "3D Gaussian Splatting for Real-Time Radiance Field Rendering"
https://repo-sam.inria.fr/fungraph/3d-gaussian-splatting/
Other
14.52k stars 1.9k forks source link

Problematic `clamp` #1046

Open kevintsq opened 5 days ago

kevintsq commented 5 days ago

https://github.com/graphdeco-inria/gaussian-splatting/blob/54c035f7834b564019656c3e3fcc3646292f727d/gaussian_renderer/__init__.py#L119

When the GS module is attached to other modules, this clamp can cause the system to fail to learn.

p.s. There are also unnecessary clamps in the code that may affect performance.

AsherJingkongChen commented 5 days ago

The comment is clear: "They will be excluded from value updates." That's why they clamp the image. Nothing should be learned from those invisible pixels.