Set camera model ID according to `database.db`?

graphdeco-inria / hierarchical-3d-gaussians

Official implementation of the SIGGRAPH 2024 paper "A Hierarchical 3D Gaussian Representation for Real-Time Rendering of Very Large Datasets"

Other

953 stars 90 forks source link

Set camera model ID according to `database.db`? #16

Open kevintsq opened 3 months ago

kevintsq commented 3 months ago

https://github.com/graphdeco-inria/hierarchical-3d-gaussians/blob/3c601568d3c0557cee3840e4ef79dce3a60ec02b/preprocess/fill_database.py#L22

This line assumes the camera model is PINHOLE. It causes failure afterward when I use a SIMPLE_PINHOLE model. Maybe a better way is to set this value according to database.db.

White-Mask-230 commented 3 months ago

Can you tell us the references you used to know that?

kevintsq commented 3 months ago

It's actually in another part of your code lol https://github.com/graphdeco-inria/hierarchical-3d-gaussians/blob/3c601568d3c0557cee3840e4ef79dce3a60ec02b/scene/colmap_loader.py#L24-L36 But something needs to be refactored to support this.

alanvinx commented 3 months ago

Hi, if I understood correctly this should be fixed now https://github.com/graphdeco-inria/hierarchical-3d-gaussians/commit/57a272cae3f9c8fd593c3686468f8f2246a81184#diff-08087f0ee34fd3281295a85603ec280eed6ad8d34e362992abe3e37b4243bbda.