search

graphdeco-inria / nerfshop

NeRFshop: Interactive Editing of Neural Radiance Fields
https://repo-sam.inria.fr/fungraph/nerfshop/
Other
451 stars 24 forks source link

esc exits app #4

Closed avclubvids closed 1 year ago

avclubvids commented 1 year ago

Hitting escape would normally cancel current operation (such as a shift-select gone wrong) but instead it closes the entire application. Unclear if this is intended or actually a crash/bug.

clementjambon commented 1 year ago

Hello @avclubvids This is not a bug. I agree with you that this makes more sense but as we built our pipeline on top of Instant-NGP, we took the decision not to change the key shortcuts introduced in the original codebase. For more information about the actual shortcuts, I invite you to check our tutorial in the README: https://github.com/graphdeco-inria/nerfshop/blob/main/README.md#editing-scenes. Furthermore, I would like to emphasize that this is not a product but the code of a research paper. We hope this will inspire people to come up with a more polished tool with a user-friendly interface and shortcuts. If you want to modify it yourself, we kindly invite you to download the code, make modifications and propose changes through pull requests, which we would be glad to accept :smile: