Adding limits to year field / filter

grapheo12 / iqps

Web-app meant for qp.metakgp.org

MIT License

20 stars 21 forks source link

Adding limits to year field / filter #15

Closed thealphadollar closed 4 years ago

thealphadollar commented 4 years ago

This PR, if merged, will add limits to the year field in all forms and models concerned.

P.S. Please test run the PR as I was not able to test on my system.

fixes #5

pep8speaks commented 4 years ago

Hello @thealphadollar! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-07-06 11:30:34 UTC

thealphadollar commented 4 years ago

@grapheo12 My advance apologies for this messy PR, I've not been able to get much time but I want to contribute and see this deployed ASAP. There are a few things you would need to do before merging this PR:

Delete duplicate functions and import them from a commonplace (such as utils).
Run and test that the code is working

Thank you.

grapheo12 commented 4 years ago

@thealphadollar Can you specify why you weren't able to test it on your system? I can fix the issue.

thealphadollar commented 4 years ago

Oh, I didn't have the time to setup everything for the test. There are no issues as such.

grapheo12 commented 4 years ago

@thealphadollar I squashed all the commits and made slight changes. Will you please allow edit from maintainers option?

grapheo12 commented 4 years ago

Thanks @thealphadollar for this amazing work.