search

grapheo12 / iqps

Web-app meant for qp.metakgp.org
MIT License
20 stars 21 forks source link

Add External Network configuration in docker-compose.yml.template #28

Closed thealphadollar closed 4 years ago

thealphadollar commented 4 years ago

The PR, if merged, will add the external network for Nginx serving in the template docker-compose.yml

This needs to be served in conjunction with https://github.com/grapheo12/ingress

thealphadollar commented 4 years ago

@grapheo12 Please suggest what other changes would be required if we are using external_network.

grapheo12 commented 4 years ago

This looks great to me. Just one thing, we don't really need the port export 8001:8001 now, do we? It doesn't cause any harm to keep it like that though. So I guess there will be a corresponding PR in wiki and ingress too. Will you do it or shall I complete the rest? @thealphadollar

thealphadollar commented 4 years ago

Closing this PR as per our conversation @grapheo12