search

grapheo12 / iqps

Web-app meant for qp.metakgp.org
MIT License
20 stars 21 forks source link

Merging install.sh and init.sh #40

Closed pasthorizon closed 3 years ago

pasthorizon commented 3 years ago

Merged install.sh and init.sh to eliminate the need to run two different scripts. The need for manually stopping the docker-compose up is eliminated by redirecting the logs to text file and periodically running a pattern match for "mysqld: ready for connections". The command docker-compose up is given from a different terminal. When the pattern matches, we stop the process and the newly created terminal is closed. We have appended the init.sh script to install.sh , which ensures its running as soon as the process is killed.

grapheo12 commented 3 years ago

Is init.sh unnecessary now? Please delete it if that is the case.

pasthorizon commented 3 years ago

@grapheo12 Changes made:)

grapheo12 commented 3 years ago

@pasthorizon There is a merge conflict due to #39. Please resolve it. Looks good to me otherwise. After removing conflict, please check if:

  1. Pause resume functionality works as expected.
  2. Your feature also works as expected. Then commit. I'll merge.
pasthorizon commented 3 years ago

Hey @grapheo12 I have made the changes. Kindly look into it

grapheo12 commented 3 years ago

Hey! There are still merge conflicts remaining. There is a whole chunk of commented out code. Please see. Don't worry about midevals. I'll handle them.