search

graphfoundation / ongdb

ONgDB is an independent fork of Neo4j® Enterprise Edition version 3.4.0.rc02 licensed under AGPLv3 and/or Community Edition licensed under GPLv3
https://www.graphfoundation.org/projects/ongdb/
391 stars 58 forks source link

checkstyle 8.26 checkstyle/checkstyle.xml ruleset blocks building ongdb #19

Closed jsoref closed 4 years ago

jsoref commented 4 years ago

The build fails (a lot)...

Neo4j Version: 3.5.15 -- 35e2c7dd1dbaa73b0536c8011f324eaf6345c131 Operating System: macOS 10.14.6

Steps to reproduce

brew tap AdoptOpenJDK/openjdk
brew cask install adoptopenjdk8-openj9
git clone ssh://git@github.com:graphfoundation/ongdb.git
cd ongdb
git checkout 3.5.15
export JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8-openj9.jdk/Contents/Home
mvn install
# hit https://github.com/neo4j/licensing-maven-plugin/pull/8
# apply patch to `neo4j/licensing-maven-plugin` and `mvn install`
mvn install

Expected behavior

working neo4j project.

Actual behavior

[INFO] --- maven-checkstyle-plugin:3.1.0:check (validate) @ neo4j-enterprise-kernel ---
[INFO] Starting audit...
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:1: File does not end with a newline. [NewlineAtEndOfFile]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:55:65: '{' at column 65 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:57:29: '{' at column 29 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:61:41: '{' at column 41 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:66:45: '(' is not followed by whitespace. [ParenPad]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:66:86: ')' is not preceded with whitespace. [ParenPad]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:66:88: '{' at column 88 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:71:27: '{' at column 27 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:75:27: '{' at column 27 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:79:46: '{' at column 46 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:84:28: '{' at column 28 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:89:30: '{' at column 30 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:94:42: '{' at column 42 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:99:44: '{' at column 44 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:104:34: '{' at column 34 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:109:36: '{' at column 36 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:114:26: '{' at column 26 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:119:36: '{' at column 36 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:124:36: '{' at column 36 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:129:54: '{' at column 54 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:134:38: '{' at column 38 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:139:26: '{' at column 26 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:144:36: '{' at column 36 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:149:36: '{' at column 36 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:154:29: '{' at column 29 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:159:46: '{' at column 46 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:166:45: '{' at column 45 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:173:53: '{' at column 53 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:178:35: '{' at column 35 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:183:35: '(' is not followed by whitespace. [ParenPad]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:183:49: ')' is not preceded with whitespace. [ParenPad]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:183:51: '{' at column 51 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:187:55: '{' at column 55 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:192:48: '{' at column 48 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:197:29: '{' at column 29 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:202:34: '{' at column 34 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:207:27: '{' at column 27 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:212:38: '(' is not followed by whitespace. [ParenPad]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:212:61: ')' is not preceded with whitespace. [ParenPad]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:212:63: '{' at column 63 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:216:35: '{' at column 35 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:221:36: '{' at column 36 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:226:33: '{' at column 33 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:231:35: '(' is not followed by whitespace. [ParenPad]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:231:59: ')' is not preceded with whitespace. [ParenPad]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:231:61: '{' at column 61 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:236:43: '{' at column 43 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:237:48: '(' is not followed by whitespace. [ParenPad]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:237:66: ')' is not preceded with whitespace. [ParenPad]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:241:63: '{' at column 63 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:242:48: '(' is not followed by whitespace. [ParenPad]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:242:66: ')' is not preceded with whitespace. [ParenPad]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:246:51: '{' at column 51 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:247:48: '(' is not followed by whitespace. [ParenPad]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:247:66: ')' is not preceded with whitespace. [ParenPad]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:251:28: '(' is not followed by whitespace. [ParenPad]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:251:57: ')' is not preceded with whitespace. [ParenPad]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:251:59: '{' at column 59 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:255:34: '{' at column 34 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:256:48: '(' is not followed by whitespace. [ParenPad]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:256:66: ')' is not preceded with whitespace. [ParenPad]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:260:30: '{' at column 30 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:261:48: '(' is not followed by whitespace. [ParenPad]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:261:66: ')' is not preceded with whitespace. [ParenPad]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:265:42: '{' at column 42 should be on a new line. [LeftCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/enterprise/builtinprocs/StubKernelTransaction.java:266: Two or more consecutive empty lines [RegexpMultiline]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/kernel/src/test/java/org/neo4j/kernel/monitoring/tracing/VerbosePageCacheTracerTest.java:130: Line is longer than 160 characters (found 171). [LineLength]
Audit done.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for ONgDB 3.5.15-SNAPSHOT:
[INFO]
[INFO] Neo4j - Build resources ............................ SUCCESS [  1.162 s]
[INFO] ONgDB .............................................. SUCCESS [ 17.943 s]
[INFO] Neo4j - Annotation Processors ...................... SUCCESS [  1.837 s]
[INFO] Zstandard .......................................... SUCCESS [  0.245 s]
[INFO] Neo4j - Common ..................................... SUCCESS [ 22.162 s]
[INFO] Neo4j - Resource interface ......................... SUCCESS [  2.939 s]
[INFO] Neo4j - Collections ................................ SUCCESS [ 13.819 s]
[INFO] Neo4j - Graph Database API ......................... SUCCESS [  7.978 s]
[INFO] Neo4j - Unsafe Access .............................. SUCCESS [  1.193 s]
[INFO] Neo4j - Concurrent ................................. SUCCESS [  4.005 s]
[INFO] Neo4j - IO ......................................... SUCCESS [04:17 min]
[INFO] Neo4j - Logging .................................... SUCCESS [  8.138 s]
[INFO] Neo4j - Configuration .............................. SUCCESS [  1.370 s]
[INFO] Neo4j - Procedure API .............................. SUCCESS [  4.937 s]
[INFO] Neo4j - Diagnostics ................................ SUCCESS [  0.185 s]
[INFO] Neo4j - Value ...................................... SUCCESS [  7.679 s]
[INFO] Neo4j - Random Value ............................... SUCCESS [  2.849 s]
[INFO] Neo4j - Kernel API ................................. SUCCESS [  3.872 s]
[INFO] Neo4j - CSV reading and parsing .................... SUCCESS [  5.923 s]
[INFO] Neo4j - Lucene Index Upgrade ....................... SUCCESS [  2.484 s]
[INFO] Neo4j - Native index ............................... SUCCESS [01:34 min]
[INFO] Neo4j - Native Spatial Index ....................... SUCCESS [01:42 min]
[INFO] Neo4j - SSL ........................................ SUCCESS [  4.878 s]
[INFO] Neo4j - Graph Database Kernel ...................... SUCCESS [05:42 min]
[INFO] Neo4j - Command Line ............................... SUCCESS [ 13.648 s]
[INFO] Neo4j - Lucene Index ............................... SUCCESS [ 40.429 s]
[INFO] Neo4j - Import Command Line Tool ................... SUCCESS [  1.766 s]
[INFO] Neo4j - JMX support ................................ SUCCESS [  7.530 s]
[INFO] Neo4j - Database Management System ................. SUCCESS [ 16.724 s]
[INFO] Neo4j - Graph Algorithms ........................... SUCCESS [  8.883 s]
[INFO] Neo4j - Code Generator ............................. SUCCESS [ 18.651 s]
[INFO] Neo4j - Legacy ..................................... SUCCESS [ 58.532 s]
[INFO] Neo4j - Community Cypher Build ..................... SUCCESS [  2.578 s]
[INFO] openCypher Front End Parent ........................ SUCCESS [  0.682 s]
[INFO] openCypher Utils ................................... SUCCESS [  7.329 s]
[INFO] openCypher Expressions ............................. SUCCESS [  3.182 s]
[INFO] openCypher AST for the Cypher Query Language ....... SUCCESS [ 15.555 s]
[INFO] openCypher Parser .................................. SUCCESS [ 28.130 s]
[INFO] openCypher Rewriting ............................... SUCCESS [ 15.058 s]
[INFO] openCypher Front End ............................... SUCCESS [ 25.205 s]
[INFO] Neo4j - Cypher Intermediate Representation ......... SUCCESS [  9.115 s]
[INFO] Neo4j - Cypher Logical Plans ....................... SUCCESS [ 11.506 s]
[INFO] Neo4j - Cypher Planner SPI ......................... SUCCESS [  1.209 s]
[INFO] Neo4j - Cypher Planner ............................. SUCCESS [02:05 min]
[INFO] Neo4j - Cypher Runtime Utilities ................... SUCCESS [ 14.098 s]
[INFO] Neo4j - Cypher Interpreted Runtime ................. SUCCESS [01:16 min]
[INFO] Neo4j - Cypher ..................................... SUCCESS [01:10 min]
[INFO] Neo4j - Security ................................... SUCCESS [  9.450 s]
[INFO] Neo4j - SLF4J Neo4j Binding ........................ SUCCESS [  2.552 s]
[INFO] Neo4j - Usage Data Collection ...................... SUCCESS [  4.852 s]
[INFO] Neo4j - Fulltext index ............................. SUCCESS [  1.817 s]
[INFO] Neo4j - Data Collector ............................. SUCCESS [  3.425 s]
[INFO] Neo4j - Bolt Protocol Version 1 .................... SUCCESS [ 35.450 s]
[INFO] Neo4j - Consistency Checker ........................ SUCCESS [ 10.814 s]
[INFO] Neo4j - Community .................................. SUCCESS [ 57.201 s]
[INFO] Neo4j - Community (Bill of Materials) .............. SUCCESS [  0.377 s]
[INFO] Neo4j - Server API ................................. SUCCESS [  4.495 s]
[INFO] Neo4j - Community Integration Tests ................ SUCCESS [  2.569 s]
[INFO] Neo4j - Community Integration Test Support ......... SUCCESS [ 17.611 s]
[INFO] Neo4j - Server ..................................... SUCCESS [04:13 min]
[INFO] Neo4j - Server Plugin Tests ........................ SUCCESS [ 19.176 s]
[INFO] Neo4j - Test Harness ............................... SUCCESS [ 58.739 s]
[INFO] Neo4j - Procedure Compiler Core .................... SUCCESS [ 12.073 s]
[INFO] Neo4j - Procedure Compiler Parent POM .............. SUCCESS [  0.080 s]
[INFO] Neo4j - Procedure Compiler Integration Tests ....... SUCCESS [ 25.690 s]
[INFO] Neo4j - Community Kernel Integration Tests ......... SUCCESS [08:45 min]
[INFO] Neo4j - Community Index Integration Tests .......... SUCCESS [08:06 min]
[INFO] Neo4j - Community Import Integration Tests ......... SUCCESS [01:15 min]
[INFO] Neo4j - Community DBMS Integration Tests ........... SUCCESS [ 21.354 s]
[INFO] Neo4j - Community Graph Algorithms Integration Tests SUCCESS [ 12.172 s]
[INFO] Neo4j - Community Consistency Checker Integration Tests SUCCESS [01:26 min]
[INFO] Neo4j - Community Bolt Integration Tests ........... SUCCESS [09:28 min]
[INFO] Neo4j - Community Generic Integration Tests ........ SUCCESS [01:10 min]
[INFO] Neo4j - Community Cypher Integration Tests ......... SUCCESS [13:44 min]
[INFO] Neo4j - Push To Cloud - Admin command .............. SUCCESS [  6.743 s]
[INFO] Neo4j - Cypher Specification Suite Tools ........... SUCCESS [  1.067 s]
[INFO] Neo4j - Cypher Acceptance .......................... SUCCESS [01:49 min]
[INFO] Neo4j - Cypher Compatibility Specification Suite ... SUCCESS [05:47 min]
[INFO] Neo4j - Cypher Expression Evaluator ................ SUCCESS [  3.093 s]
[INFO] Neo4j - Community Build ............................ SUCCESS [  5.364 s]
[INFO] ONgDB - Enterprise Graph Database Kernel Features .. FAILURE [  0.407 s]
[INFO] ONgDB - Enterprise Graph Database Auth Plugin API .. SKIPPED
[INFO] ONgDB - Enterprise Graph Database Security Features  SKIPPED
[INFO] ONgDB - Query Logging .............................. SKIPPED
[INFO] ONgDB - Communication Package ...................... SKIPPED
[INFO] ONgDB - Clustering Infrastructure .................. SKIPPED
[INFO] ONgDB - Graph DB Monitoring and Management tools ... SKIPPED
[INFO] ONgDB - Causal Clustering .......................... SKIPPED
[INFO] ONgDB - Backup Tool ................................ SKIPPED
[INFO] ONgDB - High Availability .......................... SKIPPED
[INFO] ONgDB - Metrics Kernel Extension ................... SKIPPED
[INFO] ONgDB - Enterprise ................................. SKIPPED
[INFO] ONgDB - Enterprise Cypher Build .................... SKIPPED
[INFO] ONgDB - Cypher Physical Planning ................... SKIPPED
[INFO] ONgDB - Compiled Expressions ....................... SKIPPED
[INFO] ONgDB - Cypher Slotted Runtime ..................... SKIPPED
[INFO] ONgDB - Cypher Morsel Runtime ...................... SKIPPED
[INFO] ONgDB - Enterprise Cypher .......................... SKIPPED
[INFO] ONgDB - Enterprise Server .......................... SKIPPED
[INFO] ONgDB - Enterprise Test Harness .................... SKIPPED
[INFO] ONgDB - Deferred Locks ............................. SKIPPED
[INFO] ONgDB - Procedure Compiler Enterprise tests ........ SKIPPED
[INFO] ONgDB - Cypher Acceptance, enterprise edition ...... SKIPPED
[INFO] ONgDB - Cypher Compatibility Specification Suite, enterprise edition SKIPPED
[INFO] ONgDB - Enterprise Build ........................... SKIPPED
[INFO] ONgDB - Integration Tests .......................... SKIPPED
[INFO] ONgDB - Stress Tests ............................... SKIPPED
[INFO] ONgDB - Low Level Tools ............................ SKIPPED
[INFO] Neo4j - Server Assembler ........................... SKIPPED
[INFO] Neo4j - Community Server Assembler ................. SKIPPED
[INFO] ONgDB - Server Assembler ........................... SKIPPED
[INFO] ONgDB - Packaging Build ............................ SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:25 h
[INFO] Finished at: 2020-03-03T18:27:16-05:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on project neo4j-enterprise-kernel: Failed during checkstyle execution: There are 67 errors reported by Checkstyle 8.26 with checkstyle/checkstyle.xml ruleset. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :neo4j-enterprise-kernel

apply fixes to make it happy, repeat mvn install:

[INFO] --- maven-checkstyle-plugin:3.1.0:check (validate) @ neo4j-com ---
[INFO] Starting audit...
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/com/src/test/java/org/neo4j/com/CommunicationIT.java:214:22: '}' at column 22 should be alone on a line. [RightCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/com/src/test/java/org/neo4j/com/CommunicationIT.java:233:22: '}' at column 22 should be alone on a line. [RightCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/com/src/test/java/org/neo4j/com/CommunicationIT.java:251:22: '}' at column 22 should be alone on a line. [RightCurly]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/com/src/test/java/org/neo4j/com/CommunicationIT.java:269:22: '}' at column 22 should be alone on a line. [RightCurly]

...

[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/causal-clustering/src/test/java/org/neo4j/causalclustering/scenarios/ClusterDiscoveryIT.java:134: Line is longer than 160 characters (found 172). [LineLength]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/causal-clustering/src/test/java/org/neo4j/causalclustering/scenarios/InstalledProtocolsProcedureIT.java:117: Line is longer than 160 characters (found 170). [LineLength]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/causal-clustering/src/test/java/org/neo4j/causalclustering/scenarios/BaseClusterOverviewIT.java:387: Line is longer than 160 characters (found 167). [LineLength]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/causal-clustering/src/test/java/org/neo4j/causalclustering/catchup/storecopy/StoreCopyRequestHandlerTest.java:241:34: '(' is not followed by whitespace. [ParenPad]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/causal-clustering/src/test/java/org/neo4j/causalclustering/catchup/storecopy/StoreCopyRequestHandlerTest.java:241:83: ')' is not preceded with whitespace. [ParenPad]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/causal-clustering/src/test/java/org/neo4j/causalclustering/catchup/storecopy/StoreCopyRequestHandlerTest.java:242:32: '{' at column 32 should be on a new line. [LeftCurly]

...

[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/enterprise/cypher/cypher/src/test/java/org/neo4j/test/EnterpriseTestGraphDatabaseFactory.java:1: File does not end with a newline. [NewlineAtEndOfFile]

...

[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/integrationtests/src/test/java/org/neo4j/procedure/ProcedureIT.java:244: Line is longer than 160 characters (found 165). [LineLength]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/integrationtests/src/test/java/org/neo4j/procedure/ProcedureIT.java:246: Line is longer than 160 characters (found 165). [LineLength]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/integrationtests/src/test/java/org/neo4j/procedure/ProcedureIT.java:263: Line is longer than 160 characters (found 165). [LineLength]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/integrationtests/src/test/java/org/neo4j/procedure/ProcedureIT.java:265: Line is longer than 160 characters (found 220). [LineLength]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/integrationtests/src/test/java/org/neo4j/procedure/ProcedureIT.java:282: Line is longer than 160 characters (found 165). [LineLength]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/integrationtests/src/test/java/org/neo4j/procedure/ProcedureIT.java:284: Line is longer than 160 characters (found 166). [LineLength]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/integrationtests/src/test/java/org/neo4j/procedure/ProcedureIT.java:1371: Line is longer than 160 characters (found 163). [LineLength]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/integrationtests/src/test/java/org/neo4j/TransactionTerminationIT.java:195: Two or more consecutive empty lines [RegexpMultiline]

...

[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/tools/src/test/java/org/neo4j/tools/dump/InconsistencyReportReaderTest.java:75: Line is longer than 160 characters (found 231). [LineLength]
[ERROR] /Users/jsoref/code/neo4j/neo4j-3.5/tools/src/test/java/org/neo4j/tools/org/neo4j/index/GBPTreePlayground.java:32: Using the '.*' form of import should be avoided - org.neo4j.index.internal.gbptree.*. [AvoidStarImport]

I'm trying to both get the build to pass and to some extent record the errors.

The alternative would be for someone to relax the checkstyle rules so that it doesn't trigger failure. But that's not something I understand well enough to do.

alexiudice commented 4 years ago

You can disable the checkstyling using the maven option -Dcheckstyle.skip=true

Try running this maven command to build up to the verify stage:

mvn clean verify -DfullBuild -Dlicense.skip=true -Dcheckstyle.skip=true -Dscalastyle.skip=true -DcreateChecksum=true -DskipTests
jsoref commented 4 years ago

That works:

[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  28:13 min
[INFO] Finished at: 2020-03-04T15:01:33-05:00

But it isn't documented anywhere. (It's now documented in your comment, which is slightly better than nothing.)

If people don't have something specifically against the checkstyle checks, I'd rather merge fixes for them (see #20). And if people are absolutely opposed to checkstyle checks, then the build system should be adjusted so that it doesn't enforce them.

bradnussbaum commented 4 years ago

@jsoref I started a branch (3.5-checkstyle) for fixing up the checkstyle issues. Did your commit resolve all of the checkstyle issues or just a few? I am building through now. If it resolves all of them then we can remove the -Dcheckstyle.skip=true flag from the build server so that it stays fixed. Will be nice to have this cleaned up.

jsoref commented 4 years ago

Hmm, I was running mvn install -rf :... and kept progressing the target as it failed until it stopped failing.

My naive assumption is that means it's finished. But I could be wrong if there are some code paths beyond mvn install or if -rf :... happens to not do what I'm expecting.

bradnussbaum commented 4 years ago

That should be right. I have build going now with the flag -Dcheckstyle.skip=true removed.

https://bamboo.graphfoundation.org/browse/ONGDB-ONGDB52-2

jsoref commented 4 years ago

Fwiw, I'm a bit puzzled by dade9431a4fc9f702d7b85e098152792007e33e7 by @jmsuhy