search

graphfoundation / ongdb

ONgDB is an independent fork of Neo4j® Enterprise Edition version 3.4.0.rc02 licensed under AGPLv3 and/or Community Edition licensed under GPLv3
https://www.graphfoundation.org/projects/ongdb/
387 stars 57 forks source link

Update Windows scripts with Enterprise entry point #2

Closed Gudahtt closed 5 years ago

Gudahtt commented 5 years ago

The main class for Neo4j is specified in these two Powershell scripts, yet it was missing for Enterprise. The branch for Enterprise is missing from the public Neo4j repo as well, yet it is present in the Neo4j Enterprise .zip file.

I suspect that these two lines are added by some build step in the private Neo4j repository. A diff between the ONgDB packaging scripts and the Neo4j Enterprise packaging scripts revealed that these two lines were the only difference aside from license changes.

The entry point classname was first renamed in this commit: https://github.com/neo4j/neo4j/commit/235af36e375bd3a9c7dbf1a5d816bfc9b2f0366a

It was then removed altogether in this commit: https://github.com/neo4j/neo4j/commit/d6a0ba62e2e8a7123ad18aabe5029a27cc4803c5

This problem prevents starting Neo4j from Windows using those Powershell scripts.

Gudahtt commented 5 years ago

Interestingly, it looks like they toyed with the idea of a separate "OpenEnterprise" version for a while, but then scrapped the idea.

The lines in Neo4j Enterprise aren't exactly the same as in this PR, as they have renamed their entrypoint com.neo4j.server.enterprise.CommercialEntryPoint. Note that it's under the namespace com.neo4j instead of org.neo4j.

bradnussbaum commented 5 years ago

Thank you for the PR and submitting an issue. We're aware of this and getting a fixed release out. Stay tuned.

bradnussbaum commented 5 years ago

Fix is in: https://github.com/GraphFoundation/ongdb/commit/c8d0b5510b78ae34ffa33a4443d9f7604126edda

Please have a look at latest release: https://cdn.graphfoundation.org/ongdb/dist/ongdb-enterprise-3.5.1-windows.zip