graphfoundation / ongdb

ONgDB is an independent fork of Neo4j® Enterprise Edition version 3.4.0.rc02 licensed under AGPLv3 and/or Community Edition licensed under GPLv3
https://www.graphfoundation.org/projects/ongdb/
391 stars 58 forks source link

3.6 - Sort information changes for `db.indexes()` procedure #38

Closed alexiudice closed 4 years ago

alexiudice commented 4 years ago

Commits:

Feature Added: Provides a map of the sort information including the sort property name, and sort property type. Example image below:

Screen Shot 2020-05-07 at 2 08 44 PM
alexiudice commented 4 years ago

I just realized that instead of making a copy of the FulltextSortType enum for the BuiltInProcedures another solution would be to add a dependency for ongdb-fulltext-index into the ongdb-kernel pom.

I'll try that out, though I'm not exactly sure if that could cause unintended consequences/conflicts.

alexiudice commented 4 years ago

That POM dependency solution I tried ending up causing a different cyclic error:


[ERROR] [ERROR] The projects in the reactor contain a cyclic reference: Edge between 'Vertex{label='org.graphfoundation.ongdb:ongdb-fulltext-index:3.6.0-SNAPSHOT'}' and 'Vertex{label='org.graphfoundation.ongdb:ongdb-kernel:3.6.0-SNAPSHOT'}' introduces to cycle in the graph org.graphfoundation.ongdb:ongdb-kernel:3.6.0-SNAPSHOT --> org.graphfoundation.ongdb:ongdb-fulltext-index:3.6.0-SNAPSHOT --> org.graphfoundation.ongdb:ongdb-kernel:3.6.0-SNAPSHOT @
--

What I could try to do instead is refactor FulltextSortType into the ongdb-kernel module and then import it from there when using it in ongdb-fulltext-index.

alexiudice commented 4 years ago

The refactor of FulltextSortType into the ongdb-kernel package worked as a solution. I think that is a cleaner solution than having a copy of the enum in BuiltInProcedures.