SVD++ should support source DataFrame of other column types

graphframes / graphframes

http://graphframes.github.io/graphframes

Apache License 2.0

997 stars 236 forks source link

SVD++ should support source DataFrame of other column types #70

Open felixcheung opened 8 years ago

felixcheung commented 8 years ago

It seems GraphFrames SVD++ fails if edges are not exactly of types "long", "long", "double" (scala.MatchError in patten matching on this line)

Perhaps we could support other variations, such as:

"long", "long", "float"
"int", "int", "float"
"int", "int", "double"

thunterdb commented 7 years ago

If you look at the documentation in that class, the types are documented as being expected to be double. But yes, it would be nice to support coercions.