graphhopper / directions-api-clients

API clients for various languages for the GraphHopper Directions API
https://docs.graphhopper.com/
Apache License 2.0
30 stars 36 forks source link

Added oms_key to geocoding results #10

Closed boldtrn closed 7 years ago

karussell commented 7 years ago

It is a bit ugly that swagger requires the parameter in the method signature instead of having a request object where you set the properties you want instead of filling out lots of null values...

karussell commented 7 years ago

For POST requests this is better. Is there something we can do about this for GET requests?

karussell commented 7 years ago

See eg. the mess for routing here

karussell commented 7 years ago

The issue is kind of known already: https://github.com/swagger-api/swagger-codegen/issues/3819#issuecomment-303656309

boldtrn commented 7 years ago

Should we merge this then as well?