search

graphhopper / directions-api-clients

API clients for various languages for the GraphHopper Directions API
https://docs.graphhopper.com/
Apache License 2.0
30 stars 37 forks source link

Naming collision with "configuration" in the Ruby client #34

Open RKushnir opened 5 years ago

RKushnir commented 5 years ago

In the Ruby client there's 2 separate things that end up being named GraphHopperClient::Configuration: https://github.com/graphhopper/directions-api-clients/blob/d69250ddf3c9280d0c61b6d85591650956455830/ruby/lib/directions-api-client/configuration.rb and https://github.com/graphhopper/directions-api-clients/blob/d69250ddf3c9280d0c61b6d85591650956455830/ruby/lib/directions-api-client/models/configuration.rb

As Ruby allows to re-open existing classes, there's no clear error message indicating this. These 2 things just get mixed together in an unexpected manner, making the gem unusable and failing with a confusing error.

karussell commented 5 years ago

Uhm, this is ugly. This might be related or identical to the following issue of swagger codegen: https://github.com/swagger-api/swagger-codegen/issues/8283

We are thinking about switching to the successor of swagger in this PR, but this is not yet properly planned.