Move to gh org - Githubissues

graphhopper / directions-api-clients

API clients for various languages for the GraphHopper Directions API

https://docs.graphhopper.com/

Apache License 2.0

30 stars 36 forks source link

Move to gh org #9

Closed karussell closed 7 years ago

karussell commented 7 years ago

I would like to make this repo more official to avoid confusion and propose wider usage. Also we have to deprecate https://github.com/graphhopper/directions-api-clients-route-optimization

Can you try to move or rename this repo to:

graphhopper/directions-api-clients

karussell commented 7 years ago

[x] remove the java & js folder as we have special clients here and here?
[x] move repo
[x] update docu
[x] update java repo with the new swagger.json and pull out examples&tests into a separate module to make it easy to copy the autogenerated code. Also we need a more generic swagger codegen config
- [x] deprecate route opt repo
[x] use and deploy the more generic swagger config of this repo to https://graphhopper.com/api/1/swagger.json and remove old https://graphhopper.com/api/1/vrp/swagger.json
[x] close https://github.com/graphhopper/directions-api-java-client/issues/33

oblonski commented 7 years ago

I think we need to deprecate this and this? Correct?

oblonski commented 7 years ago

What is again the difference between this here and this?

karussell commented 7 years ago

The java client you linked contains stuff not possible with this java client here e.g. an optimized Matrix client.

What is again the difference between this here and this?

The idea is to have one client for all APIs, this is just for the route optimization api.

So the idea is to use this repo as main entry and for Java and JS link to the manual improved once.

oblonski commented 7 years ago

Java and JS link to the manual improved once

Does this mean that the java opt client wont be here, but elsewhere?

karussell commented 7 years ago

Does this mean that the java opt client wont be here, but elsewhere?

Probably better if all is at one place ... hmmh, or better: we have to decide if we go for "a separate repo per language" (easier for the user) or one repo for all languages (easier for us)

oblonski commented 7 years ago

I do not mind if there is a separate client for each API since you can import them easily into a single project anyway. However, two or three different clients for the same API is silly.

boldtrn commented 7 years ago

Just moved the repo

karussell commented 7 years ago

Thanks!

karussell commented 7 years ago

Everything should be done now