graphhopper / directions-api

Issues for the GraphHopper Directions API
https://graphhopper.com/api/1/docs/
60 stars 25 forks source link

reverse geocoding result should always include name entry #36

Closed karussell closed 7 years ago

karussell commented 7 years ago

Bad example where name is missing -> https://graphhopper.com/api/1/geocode?point=52.5487429714954,-1.81602098644987&reverse=true&key=xyz

timminata commented 7 years ago

Thanks for creating the issue guys, has anyone been looking into it?

karussell commented 7 years ago

Not yet, sorry.

davenewza commented 7 years ago

@karussell: Is it possible to suggest an interim solution? If name doesn't exist, could we perhaps concatenate street, city, stateand country (if they aren't empty)?

karussell commented 7 years ago

Related https://github.com/komoot/photon/issues/199

karussell commented 7 years ago

@davenewza Probably it would be more consistent to use a fallback in the following way:

This way it behaves similar for similar queries, e.g. if you query for an address you just get street as name at the moment.

Or what would be the best for your use case?

karussell commented 7 years ago

This is now implemented as described.