search

graphhopper / geocoder-converter

Converts arbitrary geocoding responses to a GraphHopper response
https://graphhopper.com/api/1/docs/geocoding/#external-providers
Apache License 2.0
9 stars 11 forks source link

Locale should be filled #18

Closed karussell closed 7 years ago

karussell commented 8 years ago

See review: https://github.com/graphhopper/directions-api-java-client/pull/20#pullrequestreview-778871

boldtrn commented 8 years ago

I checked for Nominatim and Opencage, but both do not return a locale, but both allow for querying a locale. But there seems to be no option to view the returned locale.

We could just return the queried locale. Or we could setup a check if the given locale is a valid locale, and only return it if it is valid. Otherwise, return en. Not sure if there is another option?

karussell commented 8 years ago

Then I also see no other possibility.

boldtrn commented 7 years ago

This was fixed in https://github.com/boldtrn/graphhopper-geocoder-converter/commit/2b41c0f3505dce85072bc942f2a1abda034cec91