search

graphhopper / geocoder-converter

Converts arbitrary geocoding responses to a GraphHopper response
https://graphhopper.com/api/1/docs/geocoding/#external-providers
Apache License 2.0
9 stars 11 forks source link

Check response code of geocoding provider #29

Closed boldtrn closed 7 years ago

boldtrn commented 7 years ago

Fixes #28.

We check the response code of the provider. If the response code is not equal to 2XX, we return a 400, with a generic exception message. We log the request as Error and ask the user to contact the support.

WDYT?

karussell commented 7 years ago

Thanks looks good!

boldtrn commented 7 years ago

Thanks for the reivew :)

karussell commented 7 years ago

You mean like this?

Ups, I meant completely without this sentence. Because we normally see those errors, no need to contact us.

boldtrn commented 7 years ago

Ups, I meant completely without this sentence. Because we normally see those errors, no need to contact us.

Ah, wasn't sure. Should be fine now, will merge this PR.