search

graphhopper / geocoder-converter

Converts arbitrary geocoding responses to a GraphHopper response
https://graphhopper.com/api/1/docs/geocoding/#external-providers
Apache License 2.0
9 stars 11 forks source link

Rename OpenCageData parameters #40

Closed boldtrn closed 6 years ago

boldtrn commented 6 years ago

Currently the OCD converter allows to use the parameters nominatim and find_osm_id. Both wrap different parameters.

  • nominatim - boolean: this parameter is converted to the only_nominatim parameter of OCD
  • find_osm_id - boolean: this parameter is true by default, if you pass false this will be converted to the no_annotations call of OCD.

I think it would make more sense to use the official parameter names. These parameters haven't been documented yet, so they shouldn't be used. WDYT should we rename them?

boldtrn commented 6 years ago

As mentioned by @karussell here, let's just not document these two parameters for now.