NPE for gisgraphy provider

graphhopper / geocoder-converter

Converts arbitrary geocoding responses to a GraphHopper response

https://graphhopper.com/api/1/docs/geocoding/#external-providers

Apache License 2.0

9 stars 11 forks source link

NPE for gisgraphy provider #45

Closed karussell closed 6 years ago

karussell commented 6 years ago

@gisgraphy I'm getting for a simple "q=dresden" the following:

! java.lang.NullPointerException: null
! at com.graphhopper.converter.resources.ConverterResourceGisgraphy.buildBaseTarget(ConverterResourceGisgraphy.java:154)
! at com.graphhopper.converter.resources.ConverterResourceGisgraphy.buildGeocodingTarget(ConverterResourceGisgraphy.java:124)
! at com.graphhopper.converter.resources.ConverterResourceGisgraphy.handle(ConverterResourceGisgraphy.java:85)

karussell commented 6 years ago

Ah, that's the result if the API key is empty ...

gisgraphy commented 6 years ago

The apikey it should not be required, I have fixed it 537b8109ac6bf580d50035ebead199d955cc9b4c (included in PR)

karussell commented 6 years ago

Thanks!

boldtrn commented 6 years ago

Is this issue fixed now and we can close it or does it still exist?

karussell commented 6 years ago

Fixed with #44