graphhopper / geocoder-converter

Converts arbitrary geocoding responses to a GraphHopper response
https://graphhopper.com/api/1/docs/geocoding/#external-providers
Apache License 2.0
9 stars 11 forks source link

resource for photon #61

Closed karussell closed 4 years ago

karussell commented 4 years ago

Currently we patched photon to get our custom response format, but I would like to avoid this and update to the most recent photon version. For that the simplest solution is to add it to the list of supported providers.

boldtrn commented 4 years ago

Ah I see, so Photon would be the default then? Or would you keep the current Geocoding server as it is and as default, and add Photon additionally?

karussell commented 4 years ago

We would need to set photon as default, yes (if no provider parameter is specified). (I hope you meant this :) )

Currently we query photon directly, but this is only possible with a patched version. And I would like to use the most recent photon version without patching it. And so the easiest would be if we would add photon additionally here, so we would always query the geocoder converter regardless of the geocoder.

boldtrn commented 4 years ago

I see, thanks for the explanation, yes that should be easily possible :).

boldtrn commented 4 years ago

Photon and Pelias seem to both use more or less Geojson as the Response format. Maybe we could combine some of the classes used for Pelias and Photon?

karussell commented 4 years ago

I would keep them separated also because of the different progress and features. If on the way of implementing this identical things are needed then surely we can reuse stuff :) ?

boldtrn commented 4 years ago

Ok yes I think this makes sense :). The actual properties are quite different so the shared code is not that much.