search

graphhopper / graphhopper-navigation-example-legacy

GraphHopper Navigation as App
https://www.graphhopper.com/open-source/
Apache License 2.0
93 stars 49 forks source link

Add nav native #22

Closed boldtrn closed 5 years ago

boldtrn commented 6 years ago

This PR updates the mapbox-navigation-ui dependency to the latest version. This version contains the closed source nav native library.

While the current version adds a lot of benefits and fixes a lot of issues I have seen a couple of new issues as well. There are cases where simulate route stops working and the position is not updated anymore, I recommend to use Lockito for testing instead. I have also seen cases where my GPS position hasn't been updated in a real life test and I needed to restart the app. These findings need further testing though.

BTW: With mapbox-android-navigation-ui:0.22.0there is a new way of requesting the location from the SDK, that's why there are changes with thelocationLayer`. My findings above could be connected to this and might be fixed in the next version. BTW2: there are some minor side changes that I don't think require a separate PR, if you think differently, let me know, then I will split them up into separate PRs.

karussell commented 6 years ago

Thanks!

I have also seen cases where my GPS position hasn't been updated in a real life test and I needed to restart the app

I have seen this with an older version as well.

boldtrn commented 6 years ago

I have seen this with an older version as well.

Thanks for letting me know, then this might be unrelated, just wanted to report it :).

devemux86 commented 6 years ago

This version contains the closed source nav native library.

Their navigation library is not fully open source?

karussell commented 6 years ago

Their navigation library is not fully open source?

Well, they currently mess around with license issues in their open source repository, yes. See (and upvote) here: https://github.com/mapbox/mapbox-navigation-android/issues/1391

boldtrn commented 5 years ago

I will close this PR due to the licensing issues with Mapbox Native.