search

graphhopper / map-matching

The map matching functionality is now located in the main repository https://github.com/graphhopper/graphhopper#map-matching
https://www.graphhopper.com/open-source/
Apache License 2.0
785 stars 273 forks source link

Failue in case that the very last two points of a track have exactly the same location #17

Closed ratrun closed 9 years ago

ratrun commented 9 years ago

One of my tracks contains two exactly same located waypoints at the very end of the track. In this case the algortihm fails. I have made a test and a hack solution which solves this case, see

https://github.com/graphhopper/map-matching/commit/992998dd829815f4cebc2961c828b49b9affc844

This hack solves the problem I had. I didn't test if two consecutive nodes at an arbitrary location somewhere in between the first and the last waypoint of a track would be also a problem and if the change would work in such a case.

karussell commented 9 years ago

Do you have an example where this occurs?

ratrun commented 9 years ago

Sorry, currently I can't reproduce the issue any more. Maybe because of the recent change in maxSearchMultiplier=50 to maxSearchMultiplier=100. I'll need to do some more tests, but his may take a while.

ratrun commented 9 years ago

I have tried a lot to reproduce the issue without success. I have changed too much in the meantime (OSM input file, graphhopper-web, parameters).

karussell commented 9 years ago

Ok, feel free to reopen at any time :)