search

graphhopper / map-matching

The map matching functionality is now located in the main repository https://github.com/graphhopper/graphhopper#map-matching
https://www.graphhopper.com/open-source/
Apache License 2.0
785 stars 273 forks source link

upgrade java versions here as well #48

Closed karussell closed 8 years ago

karussell commented 8 years ago

Related to graphhopper/graphhopper/issues/697 as master fails on travis otherwise

devemux86 commented 8 years ago

Indeed as currently map-matching has failed tests:

initializationError(com.graphhopper.matching.http.MatchServletTest)  Time elapsed: 0.01 sec  <<< ERROR!
java.lang.UnsupportedClassVersionError: com/graphhopper/http/GHServer : Unsupported major.minor version 52.0
karussell commented 8 years ago

Fixed now (only ran the tests so far)

devemux86 commented 8 years ago

The tests pass if I run Maven via command line but not inside IntelliJ (that worked previously):

Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on project map-matching-web: Compilation failure
karussell commented 8 years ago

hmmh, did you make sure you you either fetched the fresh deps for GH core or build them locally?

karussell commented 8 years ago

For Netbeans and the command line all seems fine though and travis likes it too :)

devemux86 commented 8 years ago

Yes command line works fine.

I retried with a fresh clone and same result in IDE. Apparently something with Java version. I'll have to check it.

devemux86 commented 8 years ago

I just tested latest (Java 7/8) GH with a clean IntelliJ profile (system has JDK 7 & 8) and now it fails to build the graphhopper-web module too.

The solution was to declare in IDE level that the projects have to use the JDK 8. Though I was expecting that the Maven should have taken care of it. :worried:

karussell commented 8 years ago

Though I was expecting that the Maven should have taken care of it. :worried:

That is strange. Maybe an IntelliJ bug assuming Java 7 due to the mixed Java versions we use?

devemux86 commented 8 years ago

Will need some testing. It's supposed to honor the pom declarations and not needing to make changes via the IDE. (BTW the problem happens with latest Idea 2016.1.1)

Unless additional directives need to be written in pom files.