search

graphhopper / map-matching

The map matching functionality is now located in the main repository https://github.com/graphhopper/graphhopper#map-matching
https://www.graphhopper.com/open-source/
Apache License 2.0
785 stars 274 forks source link

Feed with JSON #72

Closed karussell closed 7 years ago

karussell commented 8 years ago

Currently we accept GPX files, but JSON file (GeoJSON) would be nice too. We could reuse our work from https://github.com/graphhopper/graphhopper/pull/781

kodonnell commented 7 years ago

Possibly change this to creating a generic interface, with GPX and JSON as certain implementations? I suggest this as our data doesn't suit GPX (or a likely JSON format), which means I'm going to have to hack the source instead of extending it, which is a tad messy.

karussell commented 7 years ago

For now I would prefer to have just one implementation and convert incoming data depending on the format. But you are right: instead of having everything like the entry objects tuned and named for GPX we should aim for something more generic ("measurement"?). I'm not sure what the benefits would be if we would make e.g. the "measurement" an interface.

BTW: Ideally we could consume the same format the the web API of the core can return (type=json|gpx). And for JSON we currently not even return the time for every point but this would be important to have. Related to https://github.com/graphhopper/graphhopper/issues/311

karussell commented 7 years ago

Duplicate of #59