search

graphicore / librebarcode

Libre Barcode: barcode fonts for various barcode standards.
https://graphicore.github.io/librebarcode
SIL Open Font License 1.1
425 stars 25 forks source link

[Code128] Handle Set C in text font #15

Closed khaledhosny closed 6 years ago

khaledhosny commented 6 years ago

… and other small fixes I needed to be able to build the fonts locally.

davelab6 commented 6 years ago

fontbakery --fix-dsig is gone?

Yes, but moved to https://github.com/googlefonts/tools/blob/master/bin/gftools-fix-dsig.py

davelab6 commented 6 years ago

Anyway its so simple I think its fine to duplicate the core code here :) The GFT one isn't going to change

graphicore commented 6 years ago

LGTM so far is this ready to be merged? Also, please poke me when a new version is due.

khaledhosny commented 6 years ago

I think it is ready. I did some basic testing with all combination of numbers and non-numbers I can think of and it worked. Dave might want to do more testing, though.

graphicore commented 6 years ago

Ok, cool. I'll merge it now and will have a look at the fonts when it's time for the release (is it?).