graphicore / specimenTools

Apache License 2.0
29 stars 5 forks source link

Also added 'oblique' subfamily identifier to manual italic detection #29

Closed kontur closed 6 years ago

kontur commented 6 years ago

I've encountered myself and via feedback from users that also Oblique styles often fail to detect as "italic" from the PS entries. Expanding on the manual italic detection by extracting the "italic" string from the style name I've added checks for "oblique".

Failing to extract the italic bit causes the "italic"/"oblique" and the roman to be conflated and displayed incorrectly, in addition to a warning about duplicate font warning.

The PR should have no negative impact for fonts with correctly denoted PS table, but also catch some more spotty fonts.

graphicore commented 6 years ago

Ok, thanks.