Closed cyrilf closed 2 weeks ago
Just adding the missing button to add a serie into the demo dataset of the Stackbar dataset.
The defaultData comes from the key: vue_ui_stackbar in the stores/defaultData.js file, which is good.
defaultData
vue_ui_stackbar
stores/defaultData.js
But the keys in the localstorage are bigStackbarConfig and bigStackbarDataset maybe they should be renamed?
bigStackbarConfig
bigStackbarDataset
The file is named MakerVueUiStackbar.vue maybe it should be renamed as MakerStackbar.vue to respect the other names in this folder?
MakerVueUiStackbar.vue
MakerStackbar.vue
Closing in favor of: https://github.com/graphieros/vue-data-ui-doc/commit/43535a8b68b3ceb3b07b554ae745b87086048f44
I did take some liberties with naming here ;) (due to VueUiSparkStackbar previous liberties...)
Just adding the missing button to add a serie into the demo dataset of the Stackbar dataset.
Extras considerations:
:one:
The
defaultData
comes from the key:vue_ui_stackbar
in thestores/defaultData.js
file, which is good.But the keys in the localstorage are
bigStackbarConfig
andbigStackbarDataset
maybe they should be renamed?:two:
The file is named
MakerVueUiStackbar.vue
maybe it should be renamed asMakerStackbar.vue
to respect the other names in this folder?