graphile-contrib / postgraphile-plugin-connection-filter

Filtering on PostGraphile connections
MIT License
286 stars 32 forks source link

feat: support filtering on composite type columns #115

Closed mattbretl closed 4 years ago

mattbretl commented 5 years ago

Closes #114

TODO:

jcgsville commented 4 years ago

Just tested this with cases that I believe do not work:

Happy to provide minimal repros if that would help

mattbretl commented 4 years ago

@jcgsville Yes, minimal repros would be a huge help. :pray:

Feel free to open a new issue for this.

jcgsville commented 4 years ago

Finally got around to providing repros, and I realized that I must have been mistaken for the first and second cases. Apologies for the confusion.

And I expect the third case will be solved by https://github.com/graphile/graphile-engine/pull/615.

I'd love to see this integrated in the plugin, though. In the meantime, we are using this branch in our project 😬

EyMaddis commented 4 years ago

I think this might run into problems with composite types: https://github.com/graphile-contrib/postgraphile-plugin-connection-filter/issues/124

mattbretl commented 4 years ago

Closing this PR, since composite types are now supported in 2.0.0.

@EyMaddis I've created a new issue (#126) with a reminder to add tests related to NULL.