search

graphile / crystal-pre-merge

Repository moved
https://github.com/graphile/crystal
39 stars 7 forks source link

Use colon separator between hour and minute in UTC time offsets #331

Closed jvandermey closed 1 year ago

jvandermey commented 1 year ago

https://github.com/benjie/postgraphile-private/blob/28397564f0cc21c2dfb6d53b48553ddcec0997d6/grafast/dataplan-pg/src/codecs.ts#L962 https://github.com/benjie/postgraphile-private/blob/28397564f0cc21c2dfb6d53b48553ddcec0997d6/grafast/dataplan-pg/src/codecs.ts#L973

Although this looks like it's technically ISO 8601 compliant, the lack of a colon separating the hour and minute in the UTC offset causes issues with a lot of built-in timestamp parsers (e.g. python and java).

benjie commented 1 year ago

Mmm, indeed I’ve made it ISO8601 compatible, but not RFC3339 compatible. I will address; thanks for the heads up!