doc: fix typo - Githubissues

graphile / crystal-pre-merge

Repository moved

39 stars 10 forks source link

doc: fix typo #453

Closed dmfay closed 11 months ago

dmfay commented 11 months ago

literally the least I could do 😅 -- I did mean to find and fix a couple other doc issues but couldn't find the next docs here or in the graphile.github.io repo

https://postgraphile.org/postgraphile/next/config#schema-options doesn't mention defaultBehavior
smart-tags link at https://postgraphile.org/postgraphile/next/reserved-keywords/#non-unique-table-names is broken

benjie commented 11 months ago

Thanks! Each root folder contains a website folder for that section, e.g. the PostGraphile website is in postgraphile/website. Also the web pages have an “Edit this page” link at the bottom that should take you directly to the right markdown file.

dmfay commented 11 months ago

I've added defaultBehavior. The broken links seem like a more general problem. Any link to ./target seems affected -- on /config the screenshots are fine, but "see the V4 migration docs for more information" retains a /config/ segment.

benjie commented 11 months ago

Ah; that's interesting. It's due to the express static middleware. If you load the URLs via clicking around there's no / on the end, but if you reload the page Express redirects from /postgraphile/next/config to /postgraphile/next/config/ and that breaks the links (which are relative). Will have to figure out how to solve that properly in Docusaurus - I expected it would compile out to /-anchored links rather than using relative ones!