graphile / crystal-pre-merge

Repository moved
https://github.com/graphile/crystal
39 stars 8 forks source link

tamedevil needs identifier tracking improvements #485

Open benjie opened 1 year ago

benjie commented 1 year ago

In c16ac7ea8df4ba9878ae631785a5290836f01544 I broke a naming conflict by prepending a $; but that's not good enough in general. We need tamedevil to track all identifiers and make sure they're always unique. This is the query that caused the issue (running against test database with polymorphic schema):

query Q {
  allRelationalItems(first: 1) {
    nodes {
      id
      type
      relationalItemByParentId {
        id
        type
      }
    }
  }
}

Perhaps we should use symbols like in pg-sql2, where the symbol description is just a hint.