search

graphile / crystal-pre-merge

Repository moved
https://github.com/graphile/crystal
39 stars 10 forks source link

feat(grafast/grafserv/src/servers/deno.ts): add deno server #500

Closed nestarz closed 9 months ago

nestarz commented 10 months ago

A first stop to be used in Deno.

benjie commented 10 months ago

(Just a note to say thank you for submitting this. I'm currently super busy preparing for GraphQLConf so I might not get around to properly evaluating this until October - not least because I've not really used Deno before and will have to familiarize myself with it before taking on the maintenance of this adaptor.)

nestarz commented 9 months ago

Thanks for your review ! I will add the required changes you mention asap. Thanks for your work.

benjie commented 9 months ago

(Please be aware this PR should now be raised against https://github.com/graphile/crystal instead :heart:)

benjie commented 9 months ago

Please re-open this against the above repo. I've pushed a few more commits but I've literally no idea how to go about running this locally - it seems that Deno doesn't support running local code in npm compatibility mode? https://github.com/denoland/deno/issues/18474 Without that, I can't be certain it works, so that's the first thing to solve.

nestarz commented 9 months ago

Noted ! Thanks for your work @benjie

benjie commented 9 months ago

Incidentally if you need help doing the git-fu to move this over:

  1. Pull down these commits into your local clone (git pull --rebase)
  2. Fork the graphile/crystal repo via GitHub interface
  3. Change the remote for your existing local clone to point at the new repository (git remote set-url origin git@github.com:nestarz/<new repo name here>.git)
  4. git push -u origin patch-1

Then raise a PR :)