makeWrapPlansPlugin can be confusing because it wraps the plan before the argument plans have been applied.
Let's say someone wanted to add a plan wrapper plugin to reject requests where the "limit" of a fetch was too high. How could we see the size of first/last when they've not been applied yet (without relying on argument names).
Also, in this case we'd probably want to raise the error from nodes rather than from allRows since {allRows{totalCount}} without pagination limits is a perfectly reasonable query, whereas {allRows{nodes{id}}} would not be.
makeWrapPlansPlugincan be confusing because it wraps the plan before the argument plans have been applied.Let's say someone wanted to add a plan wrapper plugin to reject requests where the "limit" of a fetch was too high. How could we see the size of
first/lastwhen they've not been applied yet (without relying on argument names).Also, in this case we'd probably want to raise the error from
nodesrather than fromallRowssince{allRows{totalCount}}without pagination limits is a perfectly reasonable query, whereas{allRows{nodes{id}}}would not be.