graphile / crystal

🔮 Graphile's Crystal Monorepo; home to Grafast, PostGraphile, pg-introspection, pg-sql2 and much more!
https://graphile.org/
Other
12.58k stars 570 forks source link

Fix updateByNodeId bug #2064

Closed benjie closed 4 months ago

benjie commented 4 months ago

Our test coverage wasn't sufficient to catch a bug in Beta22 related to updating records by their NodeID. This PR fixes the bug and increases test coverage in this area, checking what happens with a valid ID, a null, an invalid ID, and omitting the ID entirely. It also synchronizes the approach between condition steps and patch steps.

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 437570f97e8520afaf3d0d0b514d1f4c31546b76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages | Name | Type | | -------------------------- | ----- | | graphile-build-pg | Patch | | postgraphile | Patch | | grafast | Patch | | graphile-utils | Patch | | pgl | Patch | | graphile | Patch | | @localrepo/grafast-bench | Patch | | @dataplan/json | Patch | | @dataplan/pg | Patch | | @grafserv/persisted | Patch | | grafserv | Patch | | ruru-components | Patch | | @localrepo/grafast-website | Patch | | graphile-build | Patch | | graphile-export | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR