Handle trapping errors produced by sideEffect steps

graphile / crystal

🔮 Graphile's Crystal Monorepo; home to Grafast, PostGraphile, pg-introspection, pg-sql2 and much more!

https://graphile.org/

Other

12.49k stars 568 forks source link

Handle trapping errors produced by sideEffect steps #2100

Open BowlingX opened 1 week ago

BowlingX commented 1 week ago

Description

This is a WIP demonstrating that trying to trapi errors that where produced by sideEffects is currently not working.

Performance impact

unknown

Security impact

unknown

Checklist

[ ] My code matches the project's code style and yarn lint:fix passes.
[ ] I've added tests for the new feature, and yarn test passes.
[ ] I have detailed the new feature in the relevant documentation.
[ ] I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
[ ] If this is a breaking change I've explained why.

changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: f6d3d97e2eb12a32b73d210410f4ec8a54a34bc3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

benjie commented 1 day ago

Don't attempt any further work on this; the problem is deeper than I realised. I'm rewriting part of planning to handle it.