search

graphile / crystal

🔮 Graphile's Crystal Monorepo; home to Grafast, PostGraphile, pg-introspection, pg-sql2 and much more!
https://graphile.org/
Other
12.58k stars 570 forks source link

Fix more type inference issues by not using never on execute #2112

Closed benjie closed 3 months ago

benjie commented 3 months ago

Turns out using : never like this means that typeof __ValueStep<Grafast.Context> extends ExecutableStep<infer U> ? U : never resolves to unknown rather than Grafast.Context. Fixed in other places too.

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 867f331365346fc46ed1e0d23c79719846e398f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages | Name | Type | | -------------------------- | ----- | | grafast | Patch | | @localrepo/grafast-bench | Patch | | @dataplan/json | Patch | | @dataplan/pg | Patch | | @grafserv/persisted | Patch | | grafserv | Patch | | ruru-components | Patch | | @localrepo/grafast-website | Patch | | graphile-build-pg | Patch | | graphile-build | Patch | | graphile-utils | Patch | | pgl | Patch | | postgraphile | Patch | | graphile-export | Patch | | graphile | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR